Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ユーザーリストのバナー画像をプロキシを通すように #14454

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

Fix #14450

Additional info (optional)

gif画像が通り、画像の縮小にも対応しているプロキシモードはavatarだったのでそれを使用した

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 22, 2024
@syuilo
Copy link
Member

syuilo commented Aug 22, 2024

うーーーむ
bannerなのにavatar指定なのは違和感あるわね

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Aug 22, 2024

bannerなのにavatar指定なのは違和感あるわね

それは思ったけどproxyを外部化している場合はそちらの改修も必要になるのでどうしよう・・・

@kakkokari-gtyih
Copy link
Contributor Author

ユーザーリストではgifなバナー画像が動かない仕様にするのでも良いかも

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 20.02%. Comparing base (043ab1f) to head (ddb932b).
Report is 1 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/components/MkUserInfo.vue 0.00% 2 Missing ⚠️
packages/frontend/src/components/MkUserPopup.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14454       +/-   ##
============================================
- Coverage    39.89%   20.02%   -19.87%     
============================================
  Files         1547      725      -822     
  Lines       190970   100535    -90435     
  Branches      3519     1052     -2467     
============================================
- Hits         76190    20136    -56054     
+ Misses      114187    79855    -34332     
+ Partials       593      544       -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft August 22, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

フォロー/フォローワー一覧でバナーが非常に大きな解像度で表示されている
2 participants