Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Resolve missing parseObjectId in IdService #11039

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

caipira113
Copy link
Contributor

What

Add parseObjectId to IdService in parse method.

Why

I added the "objectId" because it exists for compatibility purposes and even though the parse is implemented, it was missing in the IdService.

Additional info (optional)

None.

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #11039 (46140ab) into develop (8c7bcdf) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11039      +/-   ##
===========================================
- Coverage    77.47%   77.44%   -0.04%     
===========================================
  Files          909      907       -2     
  Lines        91516    91357     -159     
  Branches      6891     6891              
===========================================
- Hits         70906    70749     -157     
+ Misses       20610    20608       -2     
Impacted Files Coverage Δ
packages/backend/src/core/IdService.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@syuilo syuilo merged commit e8c5117 into misskey-dev:develop Jun 23, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jun 23, 2023

🙏

@caipira113 caipira113 deleted the missing_parseObjectId branch June 23, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants