Fix wrong translations #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnjX
reviewed
Aug 17, 2023
locale/drawers.he.tr
Outdated
| @@ -6,7 +6,7 @@ Empty=ריקה | |||
| Drawer Controller= | |||
| Digiline Channel= | |||
| Save= | |||
| @1 (@2% full)=@1 (תפוסה של @1%) | |||
| @1 (@2% full)=@1 (תפוסה של @2%) | |||
| @1 @2 (@3% full)=@1 @2 (תפוסה של @3%) | |||
There was a problem hiding this comment.
Suggested change
| @1 @2 (@3% full)=@1 @2 (תפוסה של @3%) | |
| @1 @2 (@3% full)=@1 @2 (@תפוסה של 3%) |
There was a problem hiding this comment.
@lnjX Your change doesn't match my change:
my way: 2%@
your way: @3%
I'm not sure which way is correct in right-to-left languages
There was a problem hiding this comment.
Ahh i see, i thought you just missed the line. Can we test this? otherwise i'm also fine with just accepting your version.
There was a problem hiding this comment.
minetest support for he is broken (https://github.com/minetest/minetest/blob/7b3ed3200325ce913a6a2d884ae1ba1ccb08aad5/src/CMakeLists.txt#L668). I'm not sure I we really can test this
There was a problem hiding this comment.
@lnjX i18ncheck.py reports your line as wrong
Error (./drawers/locale/drawers.he.tr:10): Missing placeholder(s) in translation: '@3'
lnjX
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used i18ncheck.py