Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better inventory view in drawer formspec #83

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Jul 8, 2023

previously:
grafik

after:
grafik

@SmallJoker
Copy link
Member

SmallJoker commented Jul 11, 2023

The previous layout mimics the Minetest Game chest which makes it at least a bit consistent when used with that game.

EDIT: Regardless on game consistency - wouldn't it be nicer to have uniform spacing to all sides? Something between master and your PR might look even better.

@Niklp09
Copy link
Member Author

Niklp09 commented Jul 14, 2023

done
grafik

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Will merge in a few days unless there's objections.

@SmallJoker SmallJoker merged commit 4fdba85 into minetest-mods:master Jul 16, 2023
1 check passed
@Niklp09 Niklp09 deleted the formspec branch July 16, 2023 10:44
@OgelGames
Copy link
Contributor

This breaks Mineclone2 support, because it has a 9x4 inventory. There should be a check (for mcl_core) to decide whether to use 8x4 or 9x4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants