fix(symlink): Symlinks to folder showing as files #94
Conversation
Fixed symbolic links showing up as files on Termux, specifically the '~/storage/shared' -> '/storage/emulated/0' symlink on android devices.
| const isDirectory = async (filePath) => (await fs.lstat(filePath)).isDirectory(); | ||
| const isDirectory = async (filePath) => { | ||
| return ( | ||
| (await fs.stat(filePath)).isDirectory() || |
There was a problem hiding this comment.
do we need to check both? does'nt lstat check the target if it's a symbolic link?
The lstat() function shall be equivalent to stat(), except when path refers to a symbolic link. In that case lstat() shall return information about the link, while stat() shall return information about the file the link references.
https://pubs.opengroup.org/onlinepubs/000095399/functions/lstat.html
There was a problem hiding this comment.
actually, shouldn't we only check for fs.stat? because we're interested in the target of the link?
There was a problem hiding this comment.
Yes.. But you still need lstat for a symlink to a directory to show up as directory and not file on other OS. For some reason, fs.lstat doesn't work on the ~/storage/shared symlink in Termux.. Even though it is a symlink to the /storage/emulated/0 directory on Android, NodeJS fs.lstat identifies it as a file but fs.stat identifies it as a directory..
Fixed symbolic links showing up as files on Termux, specifically the '~/storage/shared' -> '/storage/emulated/0' symlink on android devices.