Activity Indicator: Remove branching views to improve performance (#1957

)
microsoft · Feb 1, 2024 · 4669412 · 4669412
1 parent ae6228e
commit 4669412
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/ios/FluentUI/ActivityIndicator/ActivityIndicator.swift b/ios/FluentUI/ActivityIndicator/ActivityIndicator.swift
@@ -77,22 +77,16 @@ public struct ActivityIndicator: View, TokenizedControlView {
 #endif
 
         return semiRing
-            .modifyIf(state.isAnimating, { animatedView in
-                animatedView
-                    .rotationEffect(.degrees(rotationAngle), anchor: .center)
-                    .onAppear {
-                        startAnimation()
-                    }
-            })
-            .modifyIf(!state.isAnimating) { staticView in
-                staticView
-                    .onAppear {
-                        stopAnimation()
-                    }
+            .onAppear {
+                if state.isAnimating {
+                    startAnimation()
+                }
+            }
+            .opacity(!state.isAnimating && state.hidesWhenStopped ? 0 : 1)
+            .rotationEffect(.degrees(rotationAngle), anchor: .center)
+            .onChange(of: state.isAnimating) { newValue in
+                newValue ? startAnimation() : stopAnimation()
             }
-            .modifyIf(!state.isAnimating && state.hidesWhenStopped, { view in
-                view.hidden()
-            })
             .frame(width: side,
                    height: side,
                    alignment: .center)