Update condition for max version limitation & add package tags (#265)

.github/workflows/pull-request.yml

@@ -5,7 +5,7 @@ on:
     branches: [ master ]
   pull_request:
     branches: 
-      - master
+      - main
       - 'release/**'
 
 jobs:

src/MSBuildLocator/DotNetSdkLocationHelper.cs

@@ -24,7 +24,7 @@ internal static class DotNetSdkLocationHelper
         private static readonly string ExeName = IsWindows ? "dotnet.exe" : "dotnet";
         private static readonly Lazy<IList<string>> s_dotnetPathCandidates = new(() => ResolveDotnetPathCandidates());
 
-        public static VisualStudioInstance? GetInstance(string dotNetSdkPath)
+        public static VisualStudioInstance? GetInstance(string dotNetSdkPath, bool allowQueryAllRuntimeVersions)
         {
             if (string.IsNullOrWhiteSpace(dotNetSdkPath) || !File.Exists(Path.Combine(dotNetSdkPath, "Microsoft.Build.dll")))
             {
@@ -56,8 +56,9 @@ internal static class DotNetSdkLocationHelper
             // in the .NET 5 SDK rely on the .NET 5.0 runtime. Assuming the runtime that shipped with a particular SDK has the same version,
             // this ensures that we don't choose an SDK that doesn't work with the runtime of the chosen application. This is not guaranteed
             // to always work but should work for now.
-            if (major > Environment.Version.Major ||
-                (major == Environment.Version.Major && minor > Environment.Version.Minor))
+            if (!allowQueryAllRuntimeVersions && 
+                (major > Environment.Version.Major || 
+                 (major == Environment.Version.Major && minor > Environment.Version.Minor)))
             {
                 return null;
             }
@@ -69,11 +70,11 @@ internal static class DotNetSdkLocationHelper
                 discoveryType: DiscoveryType.DotNetSdk);
         }
 
-        public static IEnumerable<VisualStudioInstance> GetInstances(string workingDirectory)
+        public static IEnumerable<VisualStudioInstance> GetInstances(string workingDirectory, bool allowQueryAllRuntimes)
         {            
             foreach (var basePath in GetDotNetBasePaths(workingDirectory))
             {
-                var dotnetSdk = GetInstance(basePath);
+                var dotnetSdk = GetInstance(basePath, allowQueryAllRuntimes);
                 if (dotnetSdk != null)
                 {
                     yield return dotnetSdk;

src/MSBuildLocator/MSBuildLocator.cs

@@ -43,6 +43,14 @@ public static class MSBuildLocator
         /// </summary>
         public static bool IsRegistered => s_registeredHandler != null;
 
+        /// <summary>
+        ///     Allow discovery of .NET SDK versions that are unlikely to be successfully loaded in the current process.
+        /// </summary>
+        /// <remarks>
+        ///     Defaults to <see langword="false"/>. Set this to <see langword="true"/> only if your application has special logic to handle loading an incompatible SDK, such as launching a new process with the target SDK's runtime.
+        /// </remarks.
+        public static bool AllowQueryAllRuntimeVersions { get; set; } = false;
+
         /// <summary>
         ///     Gets a value indicating whether an instance of MSBuild can be registered.
         /// </summary>
@@ -353,7 +361,7 @@ private static IEnumerable<VisualStudioInstance> GetInstances(VisualStudioInstan
 #endif
 
 #if NETCOREAPP
-            foreach (var dotnetSdk in DotNetSdkLocationHelper.GetInstances(options.WorkingDirectory))
+            foreach (var dotnetSdk in DotNetSdkLocationHelper.GetInstances(options.WorkingDirectory, AllowQueryAllRuntimeVersions))
                 yield return dotnetSdk;
 #endif
         }

src/MSBuildLocator/Microsoft.Build.Locator.csproj

@@ -14,7 +14,8 @@
 
     <Title>MSBuild Locator</Title>
     <Description>Package that assists in locating and using a copy of MSBuild installed as part of Visual Studio 2017 or higher or .NET Core SDK 2.1 or higher.</Description>
-
+	<PackageTags>msbuildlocator;locator;buildlocator</PackageTags>
+
     <EnablePackageValidation>true</EnablePackageValidation>
     <PackageValidationBaselineVersion>1.6.1</PackageValidationBaselineVersion>
   </PropertyGroup>

version.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.6",
+  "version": "1.7",
   "assemblyVersion": "1.0.0.0",
   "publicReleaseRefSpec": [
     "^refs/heads/release/.*"