Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle disassembly buffer #1315

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Conversation

bogdan-nikitin
Copy link
Contributor

Fix #956 (comment)

The disassembly buffer is of the "nofile" type, which has not been handled. This leads to the error "cursor position outside the buffer" when more than two panes opened.

This error can be reproduced using this Dockerfile:

  1. Run container interactively. Neovim opens with an example file with a breakpoint set
  2. Type :DapContinue
  3. Type :DapStepInto few times
  4. Assembly will appear in both panes

@mfussenegger
Copy link
Owner

Thanks for the PR but this fix would have the side effect that if you're stepping from any other window with a nofile buffer (like variables window) it would switch the buffer in that window. That's not expected for uselast.

@bogdan-nikitin
Copy link
Contributor Author

Now I'm handling the disassembly buffer by checking the Vim variable b:dap_source_buf

@mfussenegger mfussenegger merged commit 281a2e4 into mfussenegger:master Aug 18, 2024
4 checks passed
@mfussenegger
Copy link
Owner

Now I'm handling the disassembly buffer by checking the Vim variable b:dap_source_buf

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug adpater reported a frame at line 74, cursor position outside buffer.
2 participants