Skip to content

Commit

Permalink
fix: Ensure docker daemon skopeo logging is output on error (#231)
Browse files Browse the repository at this point in the history
Previously only the registry inspect output was emitted, but to
diagnose certain issues the connection to docker dameon should
also be included in error logs.
  • Loading branch information
jimmidyson committed Oct 18, 2022
1 parent a0692ee commit 5e061e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/mindthegap/create/imagebundle/image_bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,15 @@ func NewCommand(out output.Output) *cobra.Command {
context.Background(),
fmt.Sprintf("%s%s", srcSkopeoScheme, srcImageName),
)
skopeoStdout = append(skopeoStdout, skopeoDaemonStdout...)
skopeoStderr = append(skopeoStderr, skopeoDaemonStderr...)
if err != nil {
out.EndOperation(false)
out.Infof("---skopeo stdout---:\n%s", skopeoStdout)
out.Infof("---skopeo stderr---:\n%s", skopeoStderr)
return err
}
srcImageManifestList = srcDaemonImageManifestList
skopeoStdout = append(skopeoStdout, skopeoDaemonStdout...)
skopeoStderr = append(skopeoStderr, skopeoDaemonStderr...)
}
out.V(4).Infof("---skopeo stdout---:\n%s", skopeoStdout)
out.V(4).Infof("---skopeo stderr---:\n%s", skopeoStderr)
Expand Down

0 comments on commit 5e061e4

Please sign in to comment.