Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove nfs provisioner app #2667

Merged
merged 2 commits into from
Sep 27, 2024
Merged

feat: remove nfs provisioner app #2667

merged 2 commits into from
Sep 27, 2024

Conversation

mhrabovcin
Copy link
Contributor

What problem does this PR solve?:

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-102775

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mhrabovcin mhrabovcin self-assigned this Sep 27, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/nfs-server-provisioner and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Sep 27, 2024
@mhrabovcin mhrabovcin added the open-kommander-pr Automatically triggers the creation of a PR in Kommander repo label Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/mh/remove-nfs-provisioner

@coveralls
Copy link

coveralls commented Sep 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11068437409

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.557%
Totals Coverage Status
Change from base Build 11059957918: 0.0%
Covered Lines: 149
Relevant Lines: 289
💛 - Coveralls

@mhrabovcin mhrabovcin closed this Sep 27, 2024
@mhrabovcin mhrabovcin reopened this Sep 27, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2024
@mhrabovcin mhrabovcin requested review from gracedo, jimmidyson and alembiewski and removed request for gracedo September 27, 2024 11:10
@mhrabovcin mhrabovcin merged commit 24d4cbc into main Sep 27, 2024
47 checks passed
@mhrabovcin mhrabovcin deleted the mh/remove-nfs-provisioner branch September 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidyson jimmidyson jimmidyson approved these changes

@alembiewski alembiewski Awaiting requested review from alembiewski

Assignees

@mhrabovcin mhrabovcin

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/nfs-server-provisioner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhrabovcin @coveralls @jimmidyson @mesosphere-ci @d2iq-mergebot