Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update upgrade-matrix.yaml in post-upgrade based on env variable #2654

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

lukeogg
Copy link
Contributor

@lukeogg lukeogg commented Sep 19, 2024

What problem does this PR solve?:

Updates upgrade-matrix.yaml in post-release with the value from an environment variable. The variable is set in gh-dkp

https://github.com/mesosphere/gh-dkp/pull/492 needs to be merged first.

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-100509

Special notes for your reviewer:

Test manually with:

export NKP_RELEASE_AUTOMATION_UPGRADE_MATRIX="upgrades:"
go run . post-release --version v2.21.31 --repo /Users/luke.ogg/Projects/kommander-applications

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2024
@lukeogg lukeogg added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Sep 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10950762331

Details

  • 13 of 25 (52.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 51.557%

Changes Missing Coverage Covered Lines Changed/Added Lines %
hack/release/pkg/upgradematrix/upgradematrix.go 13 18 72.22%
hack/release/cmd/postrelease/postrelease.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
hack/release/cmd/postrelease/postrelease.go 1 0.0%
Totals Coverage Status
Change from base Build 10947650573: 0.04%
Covered Lines: 149
Relevant Lines: 289

💛 - Coveralls

@lukeogg lukeogg merged commit 4116f15 into main Sep 26, 2024
16 checks passed
@lukeogg lukeogg deleted the logg/post-release-upgrade-matrix-env branch September 26, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants