Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom response message #242

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Support custom response message #242

merged 1 commit into from
Sep 4, 2024

Conversation

goccy
Copy link
Member

@goccy goccy commented Sep 3, 2024

Copy link

github-actions bot commented Sep 3, 2024

Code Metrics Report

main (228a616) #242 (da2aa5f) +/-
Coverage 66.1% 66.3% +0.1%
Code to Test Ratio 1:0.3 1:0.3 -0.0
Test Execution Time 7m8s 7m18s +10s
Details
  |                     | main (228a616) | #242 (da2aa5f) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          66.1% |          66.3% | +0.1% |
  |   Files             |             72 |             73 |    +1 |
  |   Lines             |          12183 |          12242 |   +59 |
+ |   Covered           |           8059 |           8111 |   +52 |
- | Code to Test Ratio  |          1:0.3 |          1:0.3 |  -0.0 |
  |   Code              |          37640 |          37918 |  +278 |
+ |   Test              |          12986 |          13075 |   +89 |
- | Test Execution Time |           7m8s |          7m18s |  +10s |

Code coverage of files in pull request scope (77.6% → 77.7%)

Files Coverage +/-
generator/code_generator.go 79.4% +0.3%
grpc/federation/generator/decode.go 73.3% -0.0%
grpc/federation/generator/encode.go 82.3% +0.1%
internal/testutil/builder.go 84.5% +0.1%
resolver/method.go 100.0% +100.0%
resolver/resolver.go 83.4% +0.1%
resolver/service.go 78.7% 0.0%
resolver/types.go 86.7% 0.0%
source/clone.go 75.8% 0.0%
source/file.go 65.1% -0.2%
source/location.go 0.0% 0.0%
source/location_builder.go 68.5% +0.3%

Reported by octocov

Copy link
Member

@utahta utahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goccy goccy merged commit 153ea3f into main Sep 4, 2024
4 checks passed
@goccy goccy deleted the support-custom-response branch September 4, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants