Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scheduler #227

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Improve scheduler #227

merged 4 commits into from
Aug 16, 2024

Conversation

goccy
Copy link
Member

@goccy goccy commented Aug 15, 2024

Make validation priority to the highest.
If we write the following options, the order is validationA => ( callA , validationB ) => callB .
(※ callA and validationB are called concurrently )

def { validation {} } // validationA
def { call {} } // callA
def { validation {} } // validationB
def { call {} } // callB

The important thing is that call block is executed after validation block.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

Code Metrics Report

main (4b71a55) #227 (959f33b) +/-
Coverage 65.4% 65.5% +0.1%
Code to Test Ratio 1:0.4 1:0.3 -0.0
Test Execution Time 7m8s 7m5s -3s
Details
  |                     | main (4b71a55) | #227 (959f33b) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          65.4% |          65.5% | +0.1% |
  |   Files             |             71 |             71 |     0 |
  |   Lines             |          11718 |          11799 |   +81 |
+ |   Covered           |           7669 |           7730 |   +61 |
- | Code to Test Ratio  |          1:0.4 |          1:0.3 |  -0.0 |
  |   Code              |          36608 |          36764 |  +156 |
+ |   Test              |          12836 |          12853 |   +17 |
+ | Test Execution Time |           7m8s |           7m5s |   -3s |

Code coverage of files in pull request scope (71.6% → 71.7%)

Files Coverage +/-
grpc/federation/cel.go 0.0% 0.0%
resolver/def.go 93.7% -0.4%
resolver/graph.go 87.9% +1.2%
resolver/resolver.go 82.0% +0.1%
source/file.go 64.8% +0.3%

Reported by octocov

Copy link
Member

@utahta utahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goccy goccy merged commit f6e7a58 into main Aug 16, 2024
4 checks passed
@goccy goccy deleted the improve-scheduler branch August 16, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants