Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore dangling message" #217

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Revert "Ignore dangling message" #217

merged 1 commit into from
Aug 5, 2024

Conversation

goccy
Copy link
Member

@goccy goccy commented Aug 5, 2024

Reverts #213

We need to consider this issue more carefully, so I am reverting it.

Copy link

github-actions bot commented Aug 5, 2024

Code Metrics Report

main (73eadce) #217 (ff43715) +/-
Coverage 65.2% 65.2% +0.0%
Code to Test Ratio 1:0.3 1:0.3 +0.0
Test Execution Time 7m12s 7m6s -6s
Details
  |                     | main (73eadce) | #217 (ff43715) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          65.2% |          65.2% | +0.0% |
  |   Files             |             69 |             69 |     0 |
  |   Lines             |          11755 |          11756 |    +1 |
+ |   Covered           |           7661 |           7662 |    +1 |
+ | Code to Test Ratio  |          1:0.3 |          1:0.3 |  +0.0 |
  |   Code              |          37083 |          37082 |    -1 |
+ |   Test              |          12650 |          12653 |    +3 |
+ | Test Execution Time |          7m12s |           7m6s |   -6s |

Code coverage of files in pull request scope (81.7% → 81.7%)

Files Coverage +/-
resolver/resolver.go 81.7% +0.0%

Reported by octocov

@goccy goccy merged commit 98f250e into main Aug 5, 2024
4 checks passed
@goccy goccy deleted the revert-213-dangling-msg branch August 5, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants