If any messages do not have a subfilter then don't introspect them. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for unknown anys to be mapped Signed-off-by: Aidan Jensen <aidan@artificial.com>
|
I was thinking this might need an option, as it is technically breaking existing behavior, even if it is just erroring on fewer things. |
Set to true to maintain backwards compatibility Signed-off-by: Aidan Jensen <aidan@artificial.com>
mennanov
requested changes
Jan 14, 2024
Signed-off-by: Aidan Jensen <aidan@artificial.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 86.72% 88.16% +1.44%
==========================================
Files 2 2
Lines 482 490 +8
==========================================
+ Hits 418 432 +14
+ Misses 46 42 -4
+ Partials 18 16 -2 ☔ View full report in Codecov by Sentry. |
mennanov
requested changes
Jan 18, 2024
mennanov
approved these changes
Jan 19, 2024
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for unknown anys to be mapped. The current default behavior will always try and unmarshal protobuf any messages, which can cause an issue if the contained message is not in the descriptor pool. This adds an option to only map into any messages if their is a subfield in the mask, which allows copying of an any message as a whole from struct to struct