Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that writing to /etc/passwd is no longer required #181

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Ensure that writing to /etc/passwd is no longer required #181

merged 3 commits into from
Oct 18, 2023

Conversation

zlogic
Copy link
Member

@zlogic zlogic commented Sep 28, 2023 •
edited
Loading

  • OpenShift 4 automatically updates /etc/passwd for randomly generated UIDs
    • But something caused CF Buildpack's getpwuid() to fail, most likely something to do with UNIX permissions
    • With default, out-of-the-box permissions for /etc/passwd, OpenShift 4 works correctly - so removed the code to make /etc/passwd writable, as it's not needed anymore.
  • Updated to CF Buildpack v5.0.9

@zlogic
Bumped up CF Buildpack version to v5.0.9.
8a5384d
@zlogic
Ensure that patching /etc/passwd is not required.
fac9401
@zlogic
Remove /etc/passwd emulation code.
bd8cdd2 
OpenShift already correctly adds an entry to /etc/passwd.
Perhaps the issue was caused by incorrect permissions.
@zlogic zlogic mentioned this pull request Oct 2, 2023
Open
@zlogic zlogic marked this pull request as ready for review October 9, 2023 10:53
@zlogic zlogic merged commit f67107e into latest Oct 18, 2023
1 check passed
@zlogic zlogic deleted the fix-random-uids branch October 30, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walkline walkline walkline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlogic @walkline