Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/sc 98481/bug fe vqa issues on promo code modal #893

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Bug/sc 98481/bug fe vqa issues on promo code modal #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dde4791
Bug FE VQA issues on Promo Code modal [sc-98481]
meetup-oleksandr-dudiuk Oct 11, 2023
f8cd8e1
some changes
meetup-oleksandr-dudiuk Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assets/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7356,6 +7356,9 @@ Breakpoints | Property | Variants
.tw-box-border {
box-sizing: border-box; }

.tw-block {
display: block; }

.tw-flex {
display: flex; }

Expand Down Expand Up @@ -7452,6 +7455,9 @@ Breakpoints | Property | Variants
padding-top: 0.125rem;
padding-bottom: 0.125rem; }

.tw-pb-1 {
padding-bottom: 0.25rem; }

.tw-text-center {
text-align: center; }

Expand Down
8 changes: 8 additions & 0 deletions assets/css/tailwind.min.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
box-sizing: border-box
}

.tw-block {
display: block
}

.tw-flex {
display: flex
}
Expand Down Expand Up @@ -149,6 +153,10 @@
padding-bottom: 0.125rem
}

.tw-pb-1 {
padding-bottom: 0.25rem
}

.tw-text-center {
text-align: center
}
Expand Down
6 changes: 3 additions & 3 deletions src/forms/__snapshots__/select.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`A11y class pass through on labelClassName should hide the label when a11yHide is passed as a label class 1`] = `
<Fragment>
<FieldLabel
className="visibility--a11yHide"
className="tw-pb-1 tw-block visibility--a11yHide"
htmlFor="testSelect"
>
Test select
Expand Down Expand Up @@ -62,7 +62,7 @@ exports[`A11y class pass through on labelClassName should hide the label when a1
exports[`A11y class pass through on labelClassName should only pass the a11y class 1`] = `
<Fragment>
<FieldLabel
className="visibility--a11yHide"
className="tw-pb-1 tw-block visibility--a11yHide"
htmlFor="testSelect"
>
Test select
Expand Down Expand Up @@ -121,7 +121,7 @@ exports[`A11y class pass through on labelClassName should only pass the a11y cla
exports[`SelectInput basic renders into the DOM 1`] = `
<Fragment>
<FieldLabel
className=""
className="tw-pb-1 tw-block"
htmlFor="testSelect"
>
Test select
Expand Down
4 changes: 2 additions & 2 deletions src/forms/__snapshots__/textInput.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ exports[`TextInput renders a required HTML <input> with expected attributes for
>
<div>
<FieldLabel
className=""
className="tw-pb-1 tw-block"
htmlFor="superhero"
>
<label
className=""
className="tw-pb-1 tw-block"
data-swarm-field-label={true}
htmlFor="superhero"
>
Expand Down
6 changes: 3 additions & 3 deletions src/forms/__snapshots__/textarea.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ exports[`Textarea should have a label when label is given 1`] = `
className="inputContainer"
>
<FieldLabel
className=""
className="tw-pb-1 tw-block"
htmlFor="super"
>
Super Hero
Expand Down Expand Up @@ -57,7 +57,7 @@ exports[`Textarea should have a required attribute when specified 1`] = `
className="inputContainer"
>
<FieldLabel
className=""
className="tw-pb-1 tw-block"
htmlFor="super"
>
Super Hero
Expand Down Expand Up @@ -85,7 +85,7 @@ exports[`Textarea should have helper text when helper text is given 1`] = `
className="inputContainer"
>
<FieldLabel
className=""
className="tw-pb-1 tw-block"
htmlFor="super"
>
Super Hero
Expand Down
2 changes: 1 addition & 1 deletion src/utils/a11yPassThrough.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import cx from 'classnames';
// needed to allow for a11y cases for screen readers with mutli step forms where inputs are
// conditionally rendered
export default (className = '') =>
cx({
cx('tw-pb-1 tw-block', {
'visibility--a11yHide': className.includes('visibility--a11yHide'),
'visibility--a11yShow': className.includes('visiblity--a11yShow'),
});
Loading