Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactored master branch #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Mar 27, 2023

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from neoclust March 27, 2023 21:05
@sourcery-ai
Copy link
Author

sourcery-ai bot commented Mar 27, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.57%.

Quality metrics Before After Change
Complexity 6.20 ⭐ 5.38 ⭐ -0.82 👍
Method Length 44.25 ⭐ 44.08 ⭐ -0.17 👍
Working memory 7.21 🙂 7.00 🙂 -0.21 👍
Quality 73.37% 🙂 73.94% 🙂 0.57% 👍
Other metrics Before After Change
Lines 2715 2696 -19
Changed files Quality Before Quality After Quality Change
squashfs_override/usr/lib/python2.7/dist-packages/debconf.py 74.56% 🙂 76.51% ⭐ 1.95% 👍
squashfs_override/usr/lib/python2.7/dist-packages/enum.py 91.35% ⭐ 90.97% ⭐ -0.38% 👎
squashfs_override/usr/lib/python2.7/dist-packages/Registry/Registry.py 84.97% ⭐ 84.76% ⭐ -0.21% 👎
squashfs_override/usr/lib/python2.7/dist-packages/Registry/RegistryParse.py 73.99% 🙂 75.45% ⭐ 1.46% 👍
squashfs_override/usr/lib/python2.7/dist-packages/davos/__init__.py 70.86% 🙂 69.82% 🙂 -1.04% 👎
squashfs_override/usr/lib/python2.7/dist-packages/davos/dialog.py 80.89% ⭐ 81.11% ⭐ 0.22% 👍
squashfs_override/usr/lib/python2.7/dist-packages/davos/image_restorer.py 72.83% 🙂 69.12% 🙂 -3.71% 👎
squashfs_override/usr/lib/python2.7/dist-packages/davos/image_saver.py 52.47% 🙂 53.19% 🙂 0.72% 👍
squashfs_override/usr/lib/python2.7/dist-packages/davos/inventory.py 49.71% 😞 50.10% 🙂 0.39% 👍
squashfs_override/usr/lib/python2.7/dist-packages/davos/xmlrpc_client.py 90.90% ⭐ 90.71% ⭐ -0.19% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
squashfs_override/usr/lib/python2.7/dist-packages/Registry/RegistryParse.py VKRecord.raw_data 46 ⛔ 504 ⛔ 21 ⛔ 7.99% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
squashfs_override/usr/lib/python2.7/dist-packages/davos/inventory.py Inventory.windowsHandler 26 😞 314 ⛔ 8 🙂 35.29% 😞 Refactor to reduce nesting. Try splitting into smaller methods
squashfs_override/usr/lib/python2.7/dist-packages/debconf.py Debconf.command 22 😞 149 😞 11 😞 41.85% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
squashfs_override/usr/lib/python2.7/dist-packages/Registry/RegistryParse.py VKRecord.data 11 🙂 150 😞 17 ⛔ 42.32% 😞 Try splitting into smaller methods. Extract out complex expressions
squashfs_override/usr/lib/python2.7/dist-packages/Registry/Registry.py Registry.hive_type 11 🙂 183 😞 14 😞 42.54% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants