Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/correct async loading of Version #249

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Improve/correct async loading of Version #249

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2377ace
Fix non-async load_yaml of services.yaml
mdeweerd Aug 5, 2024
3a4fe27
Merge branch 'dev' of github.com:mdeweerd/zha-toolkit into dev
mdeweerd Aug 5, 2024
e66736f
Fix #241 blocking call
mdeweerd Aug 5, 2024
28a202c
Merge branch 'dev' of github.com:mdeweerd/zha-toolkit into dev
mdeweerd Aug 5, 2024
5806cc4
Merge branch 'dev' of github.com:mdeweerd/zha-toolkit into dev
mdeweerd Aug 7, 2024
354b9fc
Merge branch 'dev' of github.com:mdeweerd/zha-toolkit into dev
mdeweerd Aug 8, 2024
c321250
Improve/correct async loading of Version
mdeweerd Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions custom_components/zha_toolkit/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ async def async_setup(hass, config):
return True

LOGGER.debug("Setup services from async_setup")
register_services(hass)
await register_services(hass)

return True

Expand Down Expand Up @@ -705,7 +705,7 @@ async def toolkit_service(service):
LOGGER.debug("module is %s", module)
importlib.reload(u)

currentVersion = hass.async_add_executor_job(u.getVersion)
currentVersion = await u.getVersion()
if currentVersion != LOADED_VERSION:
LOGGER.debug(
"Reload services because VERSION changed from %s to %s",
Expand Down
Loading