Result indicates whether requests were coalesced

mccutchen · Sep 4, 2024 · 5d71ebb · 5d71ebb
1 parent 251c348
commit 5d71ebb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/urlresolver.go b/urlresolver.go
@@ -36,6 +36,7 @@ type Result struct {
 	ResolvedURL      string
 	Title            string
 	IntermediateURLs []string
+	Coalesced        bool
 }
 
 // Resolver resolves URLs.
@@ -76,10 +77,13 @@ func (r *Resolver) Resolve(ctx context.Context, givenURL string) (Result, error)
 		givenURL = Canonicalize(u)
 	}
 
-	val, err, _ := r.singleflightGroup.Do(givenURL, func() (interface{}, error) {
+	val, err, coalesced := r.singleflightGroup.Do(givenURL, func() (interface{}, error) {
 		return r.doResolve(ctx, givenURL)
 	})
-	return val.(Result), err
+
+	result := val.(Result)
+	result.Coalesced = coalesced
+	return result, err
 }
 
 func (r *Resolver) doResolve(ctx context.Context, givenURL string) (Result, error) {

diff --git a/urlresolver_test.go b/urlresolver_test.go
@@ -460,6 +460,7 @@ func TestResolver(t *testing.T) {
 		wantResult := Result{
 			Title:       "title",
 			ResolvedURL: srv.URL,
+			Coalesced:   true,
 		}
 
 		resolver := New(http.DefaultTransport, 0)