Allow to keep setup command in venv #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracting OLD_* paths
…setup-command Allow to keep setup command in venv
matthewfeickert
requested changes
Aug 28, 2024
There was a problem hiding this comment.
@AlexanderHeidelbach I don't think this is working as expected. Can you give me a minimum reproducer of how you're trying to use this to setup an environment on CVMFS with this?
| EOT | ||
| ) | ||
| _SET_PYTHONPATH+=$'\n' | ||
| if [ "${_keep_setup}" = true ]; then |
There was a problem hiding this comment.
So maybe what we could do is guard this a bit so that before using _keep_setup we check to see if _setup_command is set and if not error out as the intended use case here is to use --setup <some setup command> --keep-setup.
There was a problem hiding this comment.
I would check for the correct usage directly in the beginning such that the venv is not even created if the intended use case is not met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to allow the injection of the setup command of the cvmfs environment to the
activatescript of the createdvenv. This allows the user to automatically set up the cvmfs environment when reactivating thevenv.