-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to gh actions #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, @isacikgoz! Two questions below.
.github/workflows/ci.yml
Outdated
- name: Setup Node | ||
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0 | ||
- name: Checkout mattermost | ||
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0 | ||
with: | ||
repository: mattermost/mattermost | ||
path: mattermost | ||
- name: Build | ||
run: | | ||
cd mattermost/api | ||
make build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels weird that we pick this one thing to build and test with mattermost-govet
, but not all the other clients of the tool, e.g. the license checker, etc.
Do we actually need to test this on "both sides"? Should we just continue doing this in the monorepo? (Should mattermost-govet
be part of the monorepo... 🤔)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense if we can collate tools like govet under tools
directory in the monorepo. In fact, I believe it will be really helpful as I always lost the track what tools we have. Maybe a good item to discuss in the dev meeting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0 | ||
with: | ||
repository: mattermost/mattermost | ||
path: mattermost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific branch name ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test with master ideally, though, this project will be removed to mattermost/mattermost
.
@toninis can we merge despite the errors from circle ci, I don't have the permissions. |
Yep . I am changing the required tests and disabling the project from CircleCI as we speak |
Summary
Built on top of #36 this is the base for migrating to GH Actions.