Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing NATS connection #3345

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Reuse existing NATS connection #3345

merged 1 commit into from
Mar 22, 2024

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 22, 2024

If using external NATS, we opened unnecessary connections. This now re-uses existing connections.

@S7evinK S7evinK requested a review from a team as a code owner March 22, 2024 20:40
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.45%. Comparing base (b9abbf7) to head (3e14451).

Files Patch % Lines
setup/jetstream/nats.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3345      +/-   ##
==========================================
+ Coverage   67.42%   67.45%   +0.02%     
==========================================
  Files         521      521              
  Lines       47027    47030       +3     
==========================================
+ Hits        31708    31723      +15     
+ Misses      11355    11345      -10     
+ Partials     3964     3962       -2     
Flag Coverage Δ
unittests 52.58% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit 81f73c9 into main Mar 22, 2024
19 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/nats-conn branch March 22, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant