Fix usage of strict=True for zip in cp2k.outputs
#4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
changed the title
strict=True during zip in cp2k.outputsstrict=True for zip in cp2k.outputs
DanielYang59
force-pushed
the
fix-cp2k-zip-strict
branch
from
8ef9e96
to
ebf2608
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
strict=Trueduringzipincp2k.outputs, to fix Parsing cp2k output fails after v2024.8.9 release. #4079I have to revert to
strict=Falsefor now, but it's better if we could know the reason for such mismatch. Anyone experienced with CP2K please feel free to comment.