Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup numpydependency in pyproject #3970

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Dedup numpydependency in pyproject #3970

merged 2 commits into from
Aug 3, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 3, 2024

thanks @DanielYang59 👍

@janosh janosh added dependencies Dependency issues and PRs fix Bug fix PRs labels Aug 3, 2024
@janosh janosh enabled auto-merge (squash) August 3, 2024 11:08
@janosh janosh merged commit 380a81b into master Aug 3, 2024
35 checks passed
@janosh janosh deleted the dedup-numpy-pyproject branch August 3, 2024 11:19
@DanielYang59
Copy link
Contributor

All good! Can you leave this to me? :)

"PLR2004", # magic-value-comparison TODO fix these

@DanielYang59
Copy link
Contributor

DanielYang59 commented Aug 3, 2024

And no pressure of course, just a gentle reminder that there are still a few typing PRs (starting from #3873, the others are branched from this) that is waiting for review :) Sorry there are all pretty big PRs, so if you prefer to have some rest during the weekend that's totally alright. Thanks!

@janosh
Copy link
Member Author

janosh commented Aug 3, 2024

starting from #3873

sorry for the wait, those PRs had dropped off my radar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency issues and PRs fix Bug fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants