Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ruff rule family "N" and "S" #3892
Enable Ruff rule family "N" and "S" #3892
Changes from 1 commit
c5f904c
9e6aefb
6d7718a
e6b4414
5075261
560ef73
ccd484f
e3cea79
39f6267
7f0ef83
156bf36
62ede68
af8af85
0e19912
e2e14d2
26ccb85
33401d4
ebb299f
c52f162
9d3c6da
4947ff5
8a75287
a51d075
84e9cdd
02a7979
abf9edd
7d09bdf
8c8b3e7
3cb9c71
d366898
ec5ea31
71b7af4
e1b5db3
732841d
67d1aa6
89e0d22
a4f2080
98f4501
f6a7275
2adac55
21022c6
9f3a8bc
d75e0c5
aa3d6cb
134a11c
f82d0a3
d0ef23d
52e8735
64a702a
91b1ea6
5a923af
bc3caa9
57848ed
94ca1fd
638a75f
5723727
2cbff0b
d65f4f4
de81808
374f711
2378f85
0ffeac4
fdf52f1
08ec70d
69802bf
684520a
9370c6f
d73aa3b
2134e59
bcf1c0b
f84c906
701faac
33c1dcd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rkingsbury Can I get some confirmation on this change please, thanks:)
black
tagfmt: on/off
here? As I'm not seeingpre-commit
formatting this file here (runningblack
directly would indeed wrap some lines, but we're not replying onblack
being the formatter).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was probably carelessly refactored by me at some point as
!r
results in single quotes. thanks for pointing this out. let's go back to what i think was the original statef'structure "{fname}"\n'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time I added this,
packmol
was VERY pecuiliar about things like single vs. double quotes in the input file. I believe I opened an issue about it at the time, and they fixed the behavior to be a little less finicky. In principle as long as the packmol unit tests pass I think we should be OK, but it might be wise to see if someone can do some additional manual testing as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the additional input and confirmation. And ping me at anytime if anything doesn't look right, thanks!