Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify state of open data stores #997

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

kbuma
Copy link
Contributor

@kbuma kbuma commented Sep 19, 2024

addresses #995

Summary

Major changes:

  • issue warning about deprecated state of open data stores upon initialization of them
  • xfail tests of open data stores that fail with numpy 2.x

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (38797c9) to head (0f47d27).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
+ Coverage   88.83%   88.84%   +0.01%     
==========================================
  Files          46       46              
  Lines        3985     3989       +4     
==========================================
+ Hits         3540     3544       +4     
  Misses        445      445              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbuma
Copy link
Contributor Author

kbuma commented Sep 19, 2024

I verified locally that the open data store tests now pass with numpy 2.x

@rkingsbury rkingsbury merged commit 64265b4 into materialsproject:main Sep 29, 2024
10 checks passed
@rkingsbury
Copy link
Collaborator

Thank you @kbuma !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants