Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsanitize in contains_flow_or_job #559

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gpetretto
Copy link
Contributor

This change in emmet materialsproject/emmet@7735bb1 leads to an error in contains_flow_or_job, due to the impossibility to call as_dict on some Enums.
This PR adds the enum_values=True to handle those cases.

In general, I am wondering if it is worth making this check every time a Flow is instantiated.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (eda2a65) to head (f0aa70d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          21       21           
  Lines        1564     1564           
  Branches      425      425           
=======================================
  Hits         1555     1555           
  Misses          9        9           
Files Coverage Δ
src/jobflow/utils/find.py 100.00% <100.00%> (ø)

@FabiPi3
Copy link
Contributor

FabiPi3 commented Mar 13, 2024

@gpetretto Fyi, I am trying to store the whole enum information in the output. I think this should fix this as well. Here are my pull requests: materialsvirtuallab/monty#640 and #565

What are your thoughts about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants