feat: make useWishlistData initial data lazy

margelo · Jul 28, 2023 · 8f6ffc8 · 8f6ffc8
1 parent e22aea5
commit 8f6ffc8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/example/src/AssetList/AssetListExample.tsx b/example/src/AssetList/AssetListExample.tsx
@@ -117,7 +117,7 @@ export const AssetListExample: React.FC<{}> = () => {
 
       <Wishlist.Component
         // @ts-expect-error: TODO: update the new useWishlistData api.
-        initialData={list}
+        initialData={() => list}
         style={styles.listContainer}
         initialIndex={0}
       >

diff --git a/example/src/Chat/ChatExample.tsx b/example/src/Chat/ChatExample.tsx
@@ -17,7 +17,7 @@ const START_LOADING_ITEM = { type: 'loading', key: 'start-loading' } as any;
 const END_LOADING_ITEM = { type: 'loading', key: 'end-loading' } as any;
 
 export default function App() {
-  const data = useWishlistData<ChatItem>([]);
+  const data = useWishlistData<ChatItem>(() => []);
   const [loading, setLoading] = useState(true);
   const loadingStartRef = useRef(false);
   const loadingEndRef = useRef(false);

diff --git a/src/WishlistData.ts b/src/WishlistData.ts
@@ -26,7 +26,7 @@ export interface WishlistDataInternal<T extends Item> extends WishlistData<T> {
  * Creates an instance of Wishlist data which can be passed to Wishlist components.
  */
 export function useWishlistData<T extends Item>(
-  initialData: Array<T>,
+  getInitialData: () => Array<T>,
 ): WishlistData<T> {
   const dataId = useGeneratedId();
   const getWishlistData = useMemo((): (() => WishlistDataInternal<T>) => {
@@ -41,7 +41,7 @@ export function useWishlistData<T extends Item>(
         return global.dataCtx[dataId] as WishlistDataInternal<T>;
       }
 
-      const currentlyRenderedCopy = createItemsDataStructure(initialData);
+      const currentlyRenderedCopy = createItemsDataStructure(getInitialData());
       const attachedListIds = new Set<string>();
       const pendingUpdates: Array<UpdateJob<T, unknown>> = [];