Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pydantic generated classes #380

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Aug 3, 2024

Resolves [#ISSUE, #ISSUE]

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • run SSSOM-Py test suite against the updated model

[Add a description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]

Unfortunately this change has been done in the past, and it caused issues while testing the pydantic class generation process. It is, given the "pattern" regex, clearly redundant though, so IMO safe to drop.

I should have kept notes what issue it caused, sorry.
@matentzn matentzn self-assigned this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant