Fix TagsInput duplicate deletion behavior #6907
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
| @@ -336,7 +336,7 @@ export const TagsInput = factory<TagsInputFactory>((_props, ref) => { | |||
| key={`${item}-${index}`} | |||
| withRemoveButton={!readOnly} | |||
| onRemove={() => { | |||
| setValue(_value.filter((i) => item !== i)); | |||
| setValue(_value.splice(index, 1)); | |||
There was a problem hiding this comment.
Is this correct? I'm seeing that clicking X to remove a tag now removes all other tags except the target
There was a problem hiding this comment.
think I should've used .toSpliced here @adelamarAtGalileo can you let me know if this resolves it?
Seems alright to me, but clearly I missed it yesterday. Storybook must not have refreshed 🤷.
There was a problem hiding this comment.
splice modifies the array and returns the removed value
toSpliced doesn't modify the array and returns the remaining values
So yes, .toSpliced should work here
There was a problem hiding this comment.
skill issue (on my behalf). I've opened a PR. Thanks for catching :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6873