Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/chart] fix: console error of barlabel #6810

Merged
merged 3 commits into from
Sep 25, 2024
Merged

[@mantine/chart] fix: console error of barlabel #6810

merged 3 commits into from
Sep 25, 2024

Conversation

Kenzo-Wada
Copy link
Contributor

fixes: #6800

@Kenzo-Wada Kenzo-Wada mentioned this pull request Sep 11, 2024
Closed
2 tasks
ckifer
ckifer reviewed Sep 11, 2024
View reviewed changes
Copy link

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry those props are included. Generally its so they can be used in the recharts Text component I guess

@slk333
Copy link
Contributor

slk333 commented Sep 16, 2024

thks for the PR

@slk333
Copy link
Contributor

slk333 commented Sep 25, 2024

still not fixed as of 7.13 afaik

@Kenzo-Wada
Copy link
Contributor Author

fixed the confict!

@rtivital rtivital merged commit afb82ca into mantinedev:master Sep 25, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckifer ckifer ckifer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bar chart console errors
4 participants
@Kenzo-Wada @slk333 @rtivital @ckifer