Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button boxstyle #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

SanjeevKumar22
Copy link

Description

Fixes #ISSUE #52 and #36

Type of Change:

  • New Feature -added neon button styling and box shadow on click of dark mode
  • Documentation-changed in readme contributor section added

How Has This Been Tested?

In live server

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@netlify
Copy link

netlify bot commented Jun 11, 2021

✔️ Deploy Preview for launchspacex ready!

🔨 Explore the source changes: a25f221

🔍 Inspect the deploy log: https://app.netlify.com/sites/launchspacex/deploys/60c390e634300f0008e41a9d

😎 Browse the preview: https://deploy-preview-55--launchspacex.netlify.app/

@SanjeevKumar22
Copy link
Author

Screenshot (304)
Screenshot 2021-06-11 124223

@manankohlii
Copy link
Owner

Hello @SanjeevKumar22 the website is not responsive with these changes. And will have to put this issue on hold right now, waiting for the background to change, then will get an idea about the colours to be added.
Screenshot_20210611-125631.jpg

@SanjeevKumar22
Copy link
Author

Screenshot 2021-06-11 133244

@SanjeevKumar22
Copy link
Author

its a image background and dark cant apply
asssign me i will work on that

@manankohlii
Copy link
Owner

Already assigned someone to work on a particles.js background. And the colours you have used are too bright, the website should look neat and simple. Please wait for a few days and keep checking for updates in master!

@manankohlii
Copy link
Owner

@SanjeevKumar22 PR has merge conflicts, check for changes in the master branch. And try to add similar colours if adding a button.

@manankohlii manankohlii changed the title button boxstyle readme button boxstyle Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants