Fix basic auth (#72)

* fix basic auth * version 0.9.8 * add github sample
mamantoha · Mar 18, 2018 · f87ab28 · f87ab28
1 parent 354ad2e
commit f87ab28
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/samples/github.cr b/samples/github.cr
@@ -0,0 +1,14 @@
+require "../crest"
+
+user = ENV["GITHUB_USER"]
+key = ENV["GITHUB_KEY"]
+
+client = Crest::Resource.new(
+  "https://api.github.com",
+  user: user,
+  password: key,
+  logging: true,
+)
+
+response = client["/search/repositories?q=language=Crystal"].get
+puts response.body
diff --git a/shard.yml b/shard.yml
@@ -1,5 +1,5 @@
 name: crest
-version: 0.9.7
+version: 0.9.8
 
 authors:
   - Anton Maminov <anton.maminov@gmail.com>

diff --git a/src/crest/request.cr b/src/crest/request.cr
@@ -152,7 +152,7 @@ module Crest
     private def basic_auth(user, password)
       return unless user && password
 
-      value = "Basic " + Base64.encode(user + ":" + password).chomp
+      value = "Basic #{Base64.strict_encode("#{user}:#{password}")}"
       @headers.add("Authorization", value)
     end
 

diff --git a/src/crest/version.cr b/src/crest/version.cr
@@ -1,3 +1,3 @@
 module Crest
-  VERSION = "0.9.7"
+  VERSION = "0.9.8"
 end