Make sure correct errors thrown when adding attacker with 'bad' entry… #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was adding entry points as strings? I actually don't like having the entry points either be integers or strings of integers, it kind of muddies the waters for no good reason. |
mrkickling
force-pushed
the
json-ints-to-str-bug
branch
from
12d9dd4
to
c1db835
Compare
|
You are right, we should change it in an earlier stage. |
mrkickling
force-pushed
the
json-ints-to-str-bug
branch
from
c1db835
to
9f24ad4
Compare
andrewbwm
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… points or reached attack steps