Bugfix: attach given model to attack graph when loading from dict/file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkickling
force-pushed
the
attack-graph-attach-model
branch
from
6d4d8a8
to
b5ad754
Compare
mrkickling
changed the title
mrkickling
force-pushed
the
attack-graph-attach-model
branch
from
6c7b7ea
to
50519de
Compare
andrewbwm
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug1:
The model was never attached before which creates issues when loading an attack graph from file and e.g. attaching attackers, this PR should fix it.
Bug2:
The asset was not attached to the recreated node before doing 'graph.add_node' which lead to a problem where .full_name was not actually giving the full name when creating the dict AttackGraph._full_name_to_node which leads to wrong keys in that dict.