Handle CC and BCC as recipients #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lradacher
reviewed
Jul 10, 2018
| for _,cc := range strings.Split(msg.Header.Get("Cc"), ",") { | ||
| recip = append(recip, strings.TrimSpace(cc)) | ||
| } | ||
| for _,bcc := range strings.Split(msg.Header.Get("Bcc"), ",") { |
There was a problem hiding this comment.
I am not sure if this works correctly. As far as I know the Bcc is no part of the header, right?
There was a problem hiding this comment.
Worked for me, I was using my fork for a while.
There was a problem hiding this comment.
This probably won't work correctly if there's a comma as part of the recipient's name (in quotes).
There was a problem hiding this comment.
Didnt think of that use case, good catch. Unfortunately I no longer use msendmail, if someone else wants to pick up this PR please feel free. I don't think it will get merged however. I've been using swaks with maildev instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #20