Use mage-os as vendor-name for composer info #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ComposerInformation class is used to extract information about the current installation from the project root composer.json and composer.lock files, for example the Magento version. To find the relevant information, it looks at the package names, using a vendor name magento. Without this change, the installed version is reported as "UNKNOWN" in the Magento admin when the mage-os/project-community-edition package is used. This change fixes the regex so it correctly identifies the installed version. In future, it may be worth generalizing this so it is easier to switch the project vendor for other distributions based on Mage-OS. Fixes issue mage-os#42.
|
Unit test failures are unrelated to PR |
|
The coding standard violations are not related to changes in PR. |
sprankhub
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The ComposerInformation class is used to extract information about the current installation from the project root composer.json and composer.lock files, for example the Magento version. To find the relevant information, it looks at the package names, using a vendor name magento.
Without this change, the installed version is reported as "UNKNOWN" in the Magento admin when the mage-os/project-community-edition package is used. This change fixes the regex so it correctly identifies the installed version.
In future, it may be worth generalizing this so it is easier to switch the project vendor for other distributions based on Mage-OS.
Fixed Issues
Fixes issue #42.
Manual testing scenarios (*)
Contribution checklist (*)