Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5-qtwebengine: fix list of build failures #25973

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

qt5-qtwebengine: fix list of build failures #25973

wants to merge 1 commit into from
+87 −0

Conversation

markemer
Copy link
Member

@markemer markemer commented Sep 28, 2024 •
edited
Loading

Description

  • Turn off following warnings qt5-qtwebengine to stop errors:
    • -Wenum-constexpr-conversion
    • -Wunused-but-set-variable
  • Fix -Wcast-function-type-struct errors in harfbuzz
  • Add missing dependencies in ninja files

Fixes: https://trac.macports.org/ticket/70850

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.0 24A335
Xcode 16.0 16A242d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@MarcusCalhoun-Lopez for port qt5.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Sep 28, 2024
@markemer markemer changed the title Qt5 qtwebengine fix qt5-qtwebengine: fix list of build failures Sep 28, 2024
@ryandesign
Copy link
Contributor

The failure in the macOS 14 CI log is:

deps/boost/1.65.1/include/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for the enumeration type 'int_float_mixture_enum' [-Wenum-constexpr-conversion]
deps/boost/1.65.1/include/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'
   24 | #   define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
      |                                               ^

This is https://trac.macports.org/ticket/70477.

The errors in the macOS 13 CI log start with:

/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/cstddef:50:9: error: no member named 'nullptr_t' in the global namespace
/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/__type_traits/is_null_pointer.h:24:49: error: use of undeclared identifier 'nullptr_t'
/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/exception:149:45: error: field has incomplete type 'exception_ptr'
/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/exception:144:24: note: definition of 'std::exception_ptr' is not complete until the closing '}'
/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/exception:149:5: error: '__abi_tag__' attribute only applies to structs, variables, functions, and namespaces
/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/usr/include/c++/v1/exception:149:55: error: expected ';' at end of declaration list

I don't know what this is.

@markemer
Copy link
Member Author

Yeah, the mac12 ones start with that too - I'm not sure the deal - the boost one I saw. Maybe I'll make this into an all purpose fixer-upper since, wow, qt is a hell of a port to build.

@markemer
Copy link
Member Author

markemer commented Sep 28, 2024 •
edited
Loading

Before I go off all half-cocked here - qtwebengine just did a patch release - gonna give that a try. Edit: yeah too much to ask

@markemer markemer force-pushed the qt5-qtwebengine-fix branch 2 times, most recently from dab0bd2 to bcc5725 Compare September 30, 2024 00:06
@markemer markemer marked this pull request as ready for review September 30, 2024 00:07
@markemer
Copy link
Member Author

It's building on 15 - oof that was an ordeal.

@markemer
Copy link
Member Author

markemer commented Oct 1, 2024 •
edited
Loading

This patch works 100% fine on my machine even from a clean --all qt5-qtwebengine - what the hell could be going on?

Or how the hell do I debug it?

2024-10-01T02:05:13.0597250Z DEBUG: system:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_aqua_qt5/qt5-qtwebengine/work/qtwebengine-5.15.16-lts" && /usr/bin/patch -t -N -p0 < '/Users/runner/work/macports-ports/macports-ports/ports/aqua/qt5/files/patch-qtwebengine-browser-build.gn.diff'
2024-10-01T02:05:13.0602170Z Executing:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_aqua_qt5/qt5-qtwebengine/work/qtwebengine-5.15.16-lts" && /usr/bin/patch -t -N -p0 < '/Users/runner/work/macports-ports/macports-ports/ports/aqua/qt5/files/patch-qtwebengine-browser-build.gn.diff'
2024-10-01T02:05:13.0787930Z patching file src/3rdparty/chromium/components/history/core/browser/BUILD.gn
2024-10-01T02:05:13.0789900Z can't find file to patch at input line 13
2024-10-01T02:05:13.0791030Z Perhaps you used the wrong -p or --strip option?
2024-10-01T02:05:13.0793420Z The text leading up to this was:
2024-10-01T02:05:13.0793980Z --------------------------
2024-10-01T02:05:13.0795030Z |--- 3rdparty/chromium/content/public/browser/BUILD.gn	2024-09-29 19:28:09
2024-10-01T02:05:13.0796150Z |+++ 3rdparty/chromium/content/public/browser/BUILD.gn	2024-09-29 19:29:18
2024-10-01T02:05:13.0796940Z --------------------------
2024-10-01T02:05:13.0797360Z No file to patch.  Skipping patch.
2024-10-01T02:05:13.0797830Z 1 out of 1 hunk ignored
2024-10-01T02:05:13.0800640Z Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_aqua_qt5/qt5-qtwebengine/work/qtwebengine-5.15.16-lts" && /usr/bin/patch -t -N -p0 < '/Users/runner/work/macports-ports/macports-ports/ports/aqua/qt5/files/patch-qtwebengine-browser-build.gn.diff'
2024-10-01T02:05:13.0803800Z Exit code: 1
2024-10-01T02:05:13.0804490Z Error: Failed to patch qt5-qtwebengine: command execution failed
2024-10-01T02:05:13.0805230Z DEBUG: Error code: CHILDSTATUS 76596 1
2024-10-01T02:05:13.0806000Z DEBUG: Backtrace: command execution failed
2024-10-01T02:05:13.0806520Z     while executing
2024-10-01T02:05:13.0806980Z "system {*}$notty {*}$callback {*}$nice $fullcmdstring"
2024-10-01T02:05:13.0807570Z     invoked from within
2024-10-01T02:05:13.0808040Z "command_exec patch "" "< '$patch'""
2024-10-01T02:05:13.0808610Z     (procedure "portpatch::patch_main" line 41)
2024-10-01T02:05:13.0809160Z     invoked from within
2024-10-01T02:05:13.0809550Z "$procedure $targetname"
2024-10-01T02:05:13.0810870Z Error: See /opt/local/var/macports/logs/_Users_runner_work_macports-ports_macports-ports_ports_aqua_qt5/qt5-qtwebengine/main.log for details.
2024-10-01T02:05:13.0842420Z Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
2024-10-01T02:05:13.0843580Z Error: Processing of port qt5-qtwebengine failed
2024-10-01T02:05:13.0879010Z Build of 'qt5-qtwebengine' failed.

@markemer
Copy link
Member Author

markemer commented Oct 2, 2024

Ok, tonight I'm going to build VMs for mac 12-15 and pull this branch, and try and install from scratch. If that works, I'm gonna merge it.

@markemer
Copy link
Member Author

markemer commented Oct 3, 2024

Found it! A missing src from a path - not sure why it worked locally. But once I ran it from a full clean slate, blammo.

@markemer
qt5-qtwebengine: fix build errors on sequoia
c3eaa7b 
* Turn off following warnings qt5-qtwebengine to stop errors:
  * `-Wenum-constexpr-conversion`
  * `-Wunused-but-set-variable`
* Fix -Wcast-function-type-struct errors in harfbuzz
* Add missing

Fixes: https://trac.macports.org/ticket/70850
@markemer markemer marked this pull request as draft October 5, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MarcusCalhoun-Lopez MarcusCalhoun-Lopez

Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: bugfix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markemer @macportsbot @ryandesign @MarcusCalhoun-Lopez