-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the documentation reference #1361
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Hey @emmanuel-ferdman good catch, thank you! @achantavy Should these links point to Docs site or MD files in Github? https://github.com/lyft/cartography/blob/master/docs/root/usage/drift-detect.md |
Let's point to the GH page: https://lyft.github.io/cartography/usage/drift-detect.html (When we complete the CNCF donation and move the GH org we'll have to redo all those links but that's a problem for the future) |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@chandanchowdhury @achantavy updated the PR. Thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
There's something weird going on with the CI, I'll ask for help |
Pull request was closed
lets use the gh page url
Summary
PR #248 moved the location of
drift-detect.md
. This PR adjusts source to point to: https://lyft.github.io/cartography/usage/drift-detect.htmlRelated issues or links
Checklist
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
If you are changing a node or relationship:
If you are implementing a new intel module: