Adds handshake icon

[karsa-mistmere]

closes #608

Also see: #119 and feathericons/feather#444 and feathericons/feather#486

What is the purpose of this pull request?

• New Icon

Description

Adds handshake icon to represent businesses, deals, partnerships etc.

Icon use case

As above.

Alternative icon designs

See #608

Icon Design Checklist

Concept

• I have provided valid use cases for each icon.
• I have not added any a brand or logo icon.
• I have not used any hate symbols.
• I have not included any religious or political imagery.

Author, credits & license

• The icons are solely my own creation.

Naming

• I've read and followed the naming conventions
• I've named icons by what they are rather than their use case.
• I've provided meta JSON files in icons/[iconName].json.

Design

• I've read and followed the icon design guidelines
• I've made sure that the icons look sharp on low DPI displays.
• I've made sure that the icons look consistent with the icon set in size, optical volume and density.
• I've made sure that the icons are visually centered.
• I've correctly optimized all icons to two points of precision.

Before Submitting

• I've read the Contribution Guidelines.
• I've checked if there was an existing PR that solves the same issue.

[github-actions]

Added or changed icons

Preview cohesion

Preview stroke widths

DPI Preview (24px)

Icon X-rays

[jguddas]

I'm not a fan, I feel like it's very hard to identify.

[karsa-mistmere]

I'm not a fan, I feel like it's very hard to identify.

I made this alternate design but it feels a bit clunky:

[jguddas]

I'm not a fan, I feel like it's very hard to identify.

I made this alternate design but it feels a bit clunky:

Feels better, but yes a bit clunky.

[ericfennis]

@karsa-mistmere Can you post a 100% scale version?
The current hand also looks a bit clunky when it is larger than 100%

[karsa-mistmere]

[ericfennis]

@karsa-mistmere Hmm looks not "bad", it's quite recognizable in comparison with the icon in the PR.
But not perfect yet, can you maybe send the SVG? I want to give it a try.

[ericfennis]

@karsa-mistmere @jguddas I've adjusted a bit (left from karse, second one adjusted by me).
I've reduced the length of the fingers a bit. And created a curve in the thumb like the hearth-hands icon
To me, this variant of the handshake is more in line with our other hand icons.

100%:

[karsa-mistmere]

@karsa-mistmere @jguddas I've adjusted a bit (left from karse, second one adjusted by me). I've reduced the length of the fingers a bit. And created a curve in the thumb like the hearth-hands icon To me, this variant of the handshake is more in line with our other hand icons.

100%: 

I really like this one, especially how it works together with heart-handshake, can you update the PR with it?

[ericfennis]

@karsa-mistmere Updated!

[karsa-mistmere]

Should we also update heart-handshake to match this orientation? 🤔

Or alternatively mirror this one to match the current heart-handshake?

[ericfennis]

Hmm, I was looking at what Google gives me back as a handshake icon.
I suggest mirroring the handshake icon to be more conventional

[karsa-mistmere]

Hmm, I was looking at what Google gives me back as a handshake icon. I suggest mirroring the handshake icon to be more conventional

Done!

[jguddas]

What about updating the handshake heart to use the same round fingers?

[karsa-mistmere]

What about updating the handshake heart to use the same round fingers?

I've tried something similar, but does this not make it look like a regular (albeit rounded) handshake as opposed to a heart as intended?