Added setters & getters for lastSuccessfulSync

[aakarshsingh]

We found that LSC syncs were spamming our services and explored governing the lastSuccessfulSync using the PullableJndiSrcService and that helped us to reduce the spam on service restarts. At a high-level, this is what we do:

• Maintain a copy of the lastSuccessfulSync from LSC on Service Shutdown as a configuration in our DB
• On the restart, the first thing to do would be pull the saved lastSuccessfulSync and set it back using the setter
• This happens just before the synchorizer kicks in

Rough Use of this approach illustrated below:

final IService service = synchronize.getTask(PersonnelLdapSyncConfiguration.SYNC_TASK_NAME).getSourceService();
if(service instanceof PullableJndiSrcService) {
       PullableJndiSrcService srcService = (PullableJndiSrcService) service;
       Logger.log("LS1 = {0}", srcService.getLastSuccessfulSync());
       srcService.setLastSuccessfulSync(PersonnelLdapSyncConfiguration.getLastSuccessfulSync);
       Logger.log("LS2 = {0}", srcService.getLastSuccessfulSync());
}

LS1 = null
LS2 = Wed May 15 07:00:58 CDT 2024

By governing the lastSuccessfulSync, we are reducing the dataset that it returned to user for Synchronization and that in turn reduces all those extra calls to our internal services.

[rouazana]

Hello!

Not sure to completely understand your use case, in particular compared to the async facilities already present in the engine (see for example filterAsync on this documentation page).

But I'm fine with your modifications if it helps you!

[aakarshsingh]

Yeah, honestly it has been a while since we implemented it internally. But I remember that we were able to control it using filterAsync. The accessors for the lastSuccessfulSync allow us more control through our configuration and service actions.

It will be helpful for us if this gets merged, thanks!