Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cover part of helpers #92

Merged
merged 10 commits into from
Oct 23, 2023
Merged

test: cover part of helpers #92

merged 10 commits into from
Oct 23, 2023

Conversation

louisgrasset
Copy link
Owner

@louisgrasset louisgrasset commented Oct 23, 2023 •
edited
Loading

This PR adds:

  • news tests regarding the helpers
  • some fixes, especially one where urls where all replaced by the first one found

@louisgrasset louisgrasset self-assigned this Oct 23, 2023
@louisgrasset louisgrasset force-pushed the feature/tests branch 6 times, most recently from b038ae4 to 24b9b65 Compare October 23, 2023 00:57
Repository owner deleted a comment from sonarcloud bot Oct 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@louisgrasset louisgrasset merged commit 015699a into main Oct 23, 2023
8 of 9 checks passed
@louisgrasset louisgrasset deleted the feature/tests branch October 23, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@louisgrasset louisgrasset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@louisgrasset