Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make notification states immutable #12260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hduelme
Copy link
Contributor

@hduelme hduelme commented Jun 29, 2024

Ensuring that notification states are immutable helps prevent any unwanted or accidental modifications.

@rcalixte
Copy link
Member

Can you expand on the change here a little bit? What are the differences in the before/after in the user experience? Are there any examples that might be useful?

@hduelme
Copy link
Contributor Author

hduelme commented Jun 29, 2024

Currently anyone using the API (for example spices) could accidental modify the stats, for example MessageTray.Urgency.CRITICAL = 0; could accidental be executed, resulting in a wrong internal state for CRITICAL. This change prevents this. Any changes made to this would be ignored, as cinnamon don't run in strict mode. For the end-user nothing should change at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants