motd: use explicit umount/mount instead of remount #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The umount/mount construct is more robust when there is e.g. already a /etc/motd _file_ or if there is not /etc/motd mountpoint yet. The remount method fails in both of these cases. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
|
I've tested the fully-integrated change now via linux-automation/meta-lxatac#177 and it seems to work fine (immediately after the first boot and when restarting the |
KarlK90
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The umount/mount construct is more robust when there is e.g. already a
/etc/motdfile or if there is not/etc/motdmountpoint yet. The remount method fails in both of these cases.This two-stage approach was taken from #57. Using remount instead was one of the changes introduced in #77. It looks like neither I nor @KarlK90 tested this change on actual hardware, instead relying only on the demo_mode.