Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tacd,web: dependency updates #74

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Conversation

hnez
Copy link
Member

@hnez hnez commented Aug 2, 2024

Update our rust and node dependencies and also the cargo deny config format, since it started complaining about us using deprecated fields.

The npm updates bring a new version of Cloudscape, making the web page look a bit different than before and requiring a slight change to the DUT power plots. With this fix applied the interface now looks something like this:

after

Compared to what it looked like before:

before

TL;DR: Some shadows are gone and everything looks a bit more flat. It is debatable whether these are actually good changes, but since staying on an old version forever or maintaining a custom theme are not really an option there is not really a point to such discussions.

TODO before merging:

  • Test the updated build results. I wanted to see the CI results (mostly for old rust versions) before continuing with that.

The new format removes the unlicensed and default keys
(making deny the default for them and providing other options to override
it - which we do not need) and removes the copyleft field which allowed
all GPL-style licenses at once.
Instead we now have to list the LPGL (for systemd) and GPL-2.0 (for tacd)
ourself.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez hnez self-assigned this Aug 2, 2024
This does not require any formatting changes like the previous update did.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
With the most recent cloudscape components update the design of the plots
has changed in a way let the labels above them get too close to the plots
themselves, making the result look weird.

Fix that by introducint some SpaceBetween.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez hnez changed the title Dependency updates tacd,web: dependency updates Aug 2, 2024
@hnez hnez assigned KarlK90 and unassigned hnez Aug 2, 2024
@hnez hnez requested a review from KarlK90 August 2, 2024 12:38
@hnez hnez marked this pull request as ready for review August 2, 2024 12:51
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnez hnez merged commit d79854b into linux-automation:main Aug 5, 2024
14 checks passed
@hnez hnez deleted the dependency-updates branch August 5, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants