Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: setup: Simplify the setup wizard and other cleanups #51

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

hnez
Copy link
Member

@hnez hnez commented Nov 21, 2023

Previously the tacd presented every new user with a choice between two setup methods:

Screenshot 2023-11-21 at 07-13-01 LXA TAC (lxatac-00011)

The "custom bundle" was however not yet implemented and only shows a respective message when selected.
I think the custom bundle method can be integrated into the normal wizard flow once we implement it, so there is no need to keep the selection page.

I've also added a bit more description text to each wizard page. See the screenshots below for reference:

or try it out yourself:

$ rm demo_files/srv/tacd/state.json # state file in git that turns setup mode off. Remove it
$ cd web
$ npm install .
$ npm run build
$ cd -
$ cargo run --features=demo_mode --no-default-features

@hnez hnez requested a review from KarlK90 November 21, 2023 06:28
@hnez
Copy link
Member Author

hnez commented Nov 21, 2023

Hey @rohieb,

I've added the instructions on how to ssh into the TAC at the end of setup now (see the last screenshot).

@rohieb
Copy link

rohieb commented Nov 21, 2023

Hey @rohieb,

I've added the instructions on how to ssh into the TAC at the end of setup now (see the last screenshot).

Wheee, thank you!

web/src/Setup.tsx Outdated Show resolved Hide resolved
This adds a little icon to the links that helps avoid confusion when
clicking the link takes you out of the LXA TAC web ui.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The description column regularily results in the table overflowing the
available width of the page.
Limit its maximum width to prevent that.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The RAUC bundle based install method was not implemented yet and may just
as well be integrated into the main wizard flow, so we can just remove it.
While at it also get rid of the "Start Exploring" page, as it is somewhat
redundant.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
I think it looks a bit nicer this way.

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
@hnez hnez merged commit 5445b24 into linux-automation:main Jan 11, 2024
4 checks passed
@hnez hnez deleted the simplify-setup branch January 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants