-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: setup: Simplify the setup wizard and other cleanups #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @rohieb, I've added the instructions on how to ssh into the TAC at the end of setup now (see the last screenshot). |
1 task
Wheee, thank you! |
fiurin
reviewed
Nov 24, 2023
jluebbe
approved these changes
Jan 11, 2024
This adds a little icon to the links that helps avoid confusion when clicking the link takes you out of the LXA TAC web ui. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The description column regularily results in the table overflowing the available width of the page. Limit its maximum width to prevent that. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The RAUC bundle based install method was not implemented yet and may just as well be integrated into the main wizard flow, so we can just remove it. While at it also get rid of the "Start Exploring" page, as it is somewhat redundant. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
I think it looks a bit nicer this way. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
tacd
presented every new user with a choice between two setup methods:The "custom bundle" was however not yet implemented and only shows a respective message when selected.
I think the custom bundle method can be integrated into the normal wizard flow once we implement it, so there is no need to keep the selection page.
I've also added a bit more description text to each wizard page. See the screenshots below for reference:
or try it out yourself: