tacd/web: update dependencies via cargo update/npm update #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
hnez
force-pushed
the
dependency-updates
branch
from
d68072c
to
1c32620
Compare
This was referenced Oct 4, 2023
This at least gets rid of one advisory and a new tungstenite issue (RUSTSEC-2023-0065). See the corresponding tungstenite issue[1] for reference. [1]: snapview/tungstenite-rs#376 Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
hnez
force-pushed
the
dependency-updates
branch
from
1c32620
to
44a28b5
Compare
|
Hi @KarlK90, I would like to get the number of open The langdale compatibility concerns don't bother me anymore, was we are about to move on there. |
|
Looks like I should write my messages to beg for review before tagging you as reviewer ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a routine update to prevent technical debt from accumulating.
Some noteworthy changes:
We got rid of one ignored
cargo denyadvisory! 🎉Fix cargo deny error
error[vulnerability]: Tungstenite allows remote attackers to cause a denial of serviceFix cargo deny warning
warning[yanked]: detected yanked crate (try 'cargo update -p hermit-abi')The appearance of the web interface changed a bit (for the better):
before
after
Buttons in text boxes are now much more readable.
(The missing margins between alerts are not new. Those still need fixing …)
There may be other visual changes here and there but I could not find any breakages when clicking around.
TODO
meta-lxatacto at least mickledore, as the rustc version in langdale is too old forzvariant_derive v3.15.0(it requires rustc 1.64 or newer, while the currently active rustc version is 1.63.0)2023-11-03: We are about to leave langdale behind. I am fine with breaking compatibility now.
Related Pull Requests
This PR is based on another PRs that should be kept in mind:
meta-lxatacpull request that updates to thistacd, because the recipe need to contain the new dependencies: meta-lxatac-software: tacd{,-webinterface}: dependency updates meta-lxatac#61