-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dut_pwr: display notifcations on power failure #34
Conversation
case OutputState.RealtimeViolation: | ||
reason = "a realtime violation"; | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: maybe we should add a default handler in case none of the cases match. Otherwise looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially agreed but I've had a second look and think we shouldn't. In the default case we would want reason
to be null
to make sure the Alert
is set to be not visible:
tacd/web/src/TacComponents.tsx
Lines 555 to 562 in eb97382
return ( | |
<Alert | |
statusIconAriaLabel="Info" | |
visible={reason !== null} | |
action={ | |
<SpaceBetween size="xs"> | |
<MqttButton iconName="refresh" topic="/v1/dut/powered" send={"On"}> | |
Turn DUT back on |
This is however already the case when none of the case
s match, as reason
is initialized that way.
4921ecf
to
eb97382
Compare
I've resolved merge conflicts in |
eb97382
to
eb3e75f
Compare
Hi @KarlK90 can I get a new approval? The previous one was invalidated by required changes in a rebase. |
@hnez done |
The DUT powering off due to one of the possible errors may come as a surprise to the user. Help them troubleshoot by displaying a prominent error message. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The DUT powering off due to one of the possible errors may come as a surprise to the user. Help them troubleshoot by displaying a prominent error message. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Add notification on the LCD …
… and web interface if the LXA TAC's DUT Power supply shut off due to e.g. an overcurrent or overvoltage event.