Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vpj] Merge venice-hadoop-common back into VPJ #1208

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[vpj] Merge venice-hadoop-common back into VPJ #1208

merged 1 commit into from
Sep 30, 2024

Conversation

nisargthakkar
Copy link
Contributor

Merge venice-hadoop-common back into VPJ

venice-hadoop-common holds some shared classes that we want to use in our internal ETL. But in OSS, it doesn't serve a purpose other than a shared lib for venice-push-job. Move these classes back into venice-push-job

How was this PR tested?

GHCI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@nisargthakkar nisargthakkar enabled auto-merge (squash) September 30, 2024 20:35
FelixGV
FelixGV approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@FelixGV FelixGV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nisarg.

@mynameborat
Copy link
Contributor

I remember there was another util file SchemaUtils. What about that one?

@mynameborat
Copy link
Contributor

I remember there was another util file SchemaUtils. What about that one?

Sync'd up offline on this. The SchemaUtils will remain in venice-common. Thank you, @nisargthakkar

@nisargthakkar
Copy link
Contributor Author

I remember there was another util file SchemaUtils. What about that one?

This one is okay to live in venice-common since VPJ, DVC and Servers share this

@nisargthakkar nisargthakkar merged commit 450613a into linkedin:main Sep 30, 2024
44 of 45 checks passed
@nisargthakkar nisargthakkar deleted the revertHadoopCommon branch September 30, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixGV FelixGV FelixGV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisargthakkar @mynameborat @FelixGV